GitHub Issue 959: Fallback when indexing hits IO problems#7519
Open
labkey-jeckels wants to merge 5 commits intorelease26.3-SNAPSHOTfrom
Open
GitHub Issue 959: Fallback when indexing hits IO problems#7519labkey-jeckels wants to merge 5 commits intorelease26.3-SNAPSHOTfrom
labkey-jeckels wants to merge 5 commits intorelease26.3-SNAPSHOTfrom
Conversation
| try {_log.warn("error in indexer", t);} catch (Throwable x){/* */} | ||
| if (!_shuttingDown) | ||
| { | ||
| postFailureDelay(e, "Error in indexer", _log, ++consecutiveCommitFailures, INDEX_EVENT); |
Contributor
There was a problem hiding this comment.
I'm curious if we want this to happen for all errors? Or are there specific errors we care about (e.g. IOException). Maybe this question would matter less if we used consecutiveCommitFailures++ instead of preincrement. Then we wouldn't inject a 30s wait on the first error?
Contributor
Author
There was a problem hiding this comment.
_indexLoop() doesn't declare any exceptions so it's just runtimes or errors that could get through at this point, which wrap the underlying IOException in the original repro case.
I like the idea of postincrementing through, regardless of the exact original error. That should still avoid overwhelming the logs, but be a bit more optimistic about recovery. Pushed.
labkey-matthewb
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We can end up in a tight infinite logging loop if there's an IO problem when committing the full text search index.
Changes